Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ✨ Add installer rbac generator #1774

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

perdasilva
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2025
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 24b9633
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67af39e54f6e790008f3f4fe
😎 Deploy Preview https://deploy-preview-1774--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0.68027% with 146 lines in your changes missing coverage. Please review.

Project coverage is 66.40%. Comparing base (00251d6) to head (24b9633).

Files with missing lines Patch % Lines
...erator-controller/rukpak/convert/installer_rbac.go 0.68% 145 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
- Coverage   68.29%   66.40%   -1.89%     
==========================================
  Files          63       64       +1     
  Lines        5116     5263     +147     
==========================================
+ Hits         3494     3495       +1     
- Misses       1392     1537     +145     
- Partials      230      231       +1     
Flag Coverage Δ
e2e 49.76% <0.68%> (-1.96%) ⬇️
unit 54.37% <0.68%> (-1.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per G. da Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant